Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter title hover zone abnormal size #264

Closed
2 tasks done
da3dsoul1 opened this issue Dec 21, 2024 · 3 comments
Closed
2 tasks done

Chapter title hover zone abnormal size #264

da3dsoul1 opened this issue Dec 21, 2024 · 3 comments
Labels
bug Something isn't working enhancement Enhance an existing function or behavior not bug: intended This behavior is not a bug

Comments

@da3dsoul1
Copy link

mpv Information

No response

Reproduction Steps

Hover in the area below seek bar.

Expected Behavior

Limit chapter title hover zone to actual chapter title, and not that huge empty space.

Actual Behavior

Chapter title hover zone goes beyond boundaries. Here's a quick video demonstration:

2024-12-21.21-58-35.mp4

P.S.: Sorry if it's supposed to be like that, I just find it to be rather peculiar behavior.

Log File

No response

I carefully read all instructions and confirm that I did the following:

  • I tested with the latest mpv version to validate that the issue is not already fixed.
  • I provided all required information.
@da3dsoul1 da3dsoul1 added the bug Something isn't working label Dec 21, 2024
@Samillion
Copy link
Owner

It is indeed the intended behavior, similar to title.

I get what you mean though. A large empty hover area when the content is barely 100 pixels wide. The original intent was "this is all reserved for chapter title".

Maybe it should calculate pixel width based on character count of chapter_title. I'll tinker with this and come back to ya.

@Samillion Samillion added enhancement Enhance an existing function or behavior not bug: intended This behavior is not a bug labels Dec 23, 2024
@da3dsoul1
Copy link
Author

Makes sense! Btw, thank you for fixing thumbnail preview black border that was displaying behind title name. I just downloaded lua from the repo itself and noticed the bug gone. Keep up the great work!

@Samillion
Copy link
Owner

Follow up here, please. #208 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Enhance an existing function or behavior not bug: intended This behavior is not a bug
Projects
None yet
Development

No branches or pull requests

2 participants