Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemoryRegion possibly wrong on Windows #5

Open
holly-hacker opened this issue Apr 8, 2020 · 0 comments
Open

MemoryRegion possibly wrong on Windows #5

holly-hacker opened this issue Apr 8, 2020 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@holly-hacker
Copy link
Member

According to @Azukee, memory scanning on Windows is broken.

[1:01 PM] HoLLy: also what about the error you had yesterday?
[1:01 PM] HoLLy: with the memory regions starting at 0
[1:02 PM] Snowy: well in the scan you had var region
[1:02 PM] Snowy: since i think MemoryRegion is an interface
[1:02 PM] HoLLy: yea
[1:02 PM] Snowy: I just changed it to WindowsMemoryRegion and used BaseAddress and RegionStart
[1:02 PM] Snowy: and not Start and End
[1:02 PM] Snowy: so not really a fix
[1:02 PM] Snowy: but this is windows only so i just botched something together
[1:02 PM] HoLLy: oh so I didn't implement windowsmemoryregion properly then
@holly-hacker holly-hacker added bug Something isn't working good first issue Good for newcomers labels Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant