-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reparameterizing an inline C model fails #605
Labels
Comments
sasmodels/sasmodels/generate.py Lines 979 to 996 in ab4e49a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
**Partner issue of SasView/sasview#2958
** To see how to replicate issue in the SasView GUI, see above issue
Describe the bug
Reparameterizing a python model with inline C code will fail with an error in the format:
on the developer version of SasView, where
reparameterizedModel
is the reparameterized file,oldModel
is the model being reparameterized, andreparameterizedVariable
is the name of a reparameterized variable accessed in inline C code withinoldModel
.This bug occurs if any inline C code is included in the model, even if a separate C file is defined using
source = []
in the main python file. However, models that have defined C code entirely in a separate file are unaffected.Note: currently, this bug only affects lamellar.py in the 1.0.7 sasmodels version, but will also affect any user-created models with inline C unless resolved
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The model should have no issues being loaded or used with the new redefinitions.
sasmodels version:
Suggested Solution:
Either deprecate using inline C code (only one model currently uses it and it is easily replaceable), or fix the reparameterization code in sasmodels.core to support inline C code.
The text was updated successfully, but these errors were encountered: