Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(keyBindings): Open/close inspector and Dev Mode keybindings working with Dev Mode disabled #1844

Open
luisecm opened this issue Feb 12, 2024 · 2 comments
Assignees
Labels
assigned 💻 bug 🐛 Settings Tickets that have to do with Settings

Comments

@luisecm
Copy link
Contributor

luisecm commented Feb 12, 2024

On MacOS

  1. Login with account with Developer Settings hidden
  2. Press keybinding for Open/Close Web Inspector
  3. Web Inspector is opened even though user has not enabled yet Developer Settings
  4. Press keybinding for Open/Close Dev Mode
  5. Dev Mode is opened even though user has not enabled yet Developer Settings
@luisecm luisecm added Settings Tickets that have to do with Settings bug 🐛 labels Feb 12, 2024
@lgmarchi
Copy link
Contributor

@luisecm Do you think we should block all shortcuts if user doesn't enable dev mode?

@luisecm
Copy link
Contributor Author

luisecm commented Feb 28, 2024

@lgmarchi So, as of now we have the following keyboard shortcuts:

  • Increase/Decrease Font Size and Hide/Focuse Uplink -> Actions can be performed by any user
  • Mute/Unmute microphone/sounds -> This is an experimental feature that is only enabled through Developer Settings
  • Open/Close Web Inspector and DevMode -> Both can only be enabled through Developer Settings

For me, the ones that are only enabled through Developer Settings should not be displayed on Settings Keyboard Shortcuts initially, until user enables Dev Settings

I also think that Keyboard Shortcuts should be displayed even for users that have not unlocked Developer Settings

@stavares843 @phillsatellite @InfamousVague What do you think on this?

@lgmarchi lgmarchi self-assigned this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned 💻 bug 🐛 Settings Tickets that have to do with Settings
Projects
None yet
Development

No branches or pull requests

3 participants