From ca895e24bc656120158a4faef18334f439eeb310 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Luis=20Carden=CC=83a?= <35935591+luisecm@users.noreply.github.com> Date: Tue, 9 Apr 2024 10:30:37 -0600 Subject: [PATCH 1/2] screenobject(update): fix for aria label on message reactions container --- .github/workflows/ui-automated-tests.yml | 2 ++ tests/screenobjects/chats/MessageGroupLocal.ts | 4 ++-- tests/screenobjects/chats/MessageGroupRemote.ts | 4 ++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ui-automated-tests.yml b/.github/workflows/ui-automated-tests.yml index fea14401fe..55bbceb329 100644 --- a/.github/workflows/ui-automated-tests.yml +++ b/.github/workflows/ui-automated-tests.yml @@ -71,6 +71,7 @@ jobs: uses: actions/checkout@v4 with: repository: Satellite-im/Uplink + ref: emoji_reaction_fix - name: Checkout testing directory 🔖 uses: actions/checkout@v4 @@ -145,6 +146,7 @@ jobs: uses: actions/checkout@v4 with: repository: Satellite-im/Uplink + ref: emoji_reaction_fix - name: Checkout testing directory 🔖 uses: actions/checkout@v4 diff --git a/tests/screenobjects/chats/MessageGroupLocal.ts b/tests/screenobjects/chats/MessageGroupLocal.ts index 9ef7b0b5e4..28af0454cb 100644 --- a/tests/screenobjects/chats/MessageGroupLocal.ts +++ b/tests/screenobjects/chats/MessageGroupLocal.ts @@ -27,7 +27,7 @@ const SELECTORS_WINDOWS: selectorContainer = { MESSAGE_GROUP_USER_INDICATOR_IDLE: '[name="indicator-idle"]', MESSAGE_GROUP_USER_INDICATOR_OFFLINE: '[name="indicator-offline"]', MESSAGE_GROUP_USER_INDICATOR_ONLINE: '[name="indicator-online"]', - MESSAGE_REACTION_CONTAINER: '[name="message-reaction-container"]', + MESSAGE_REACTION_CONTAINER: '[name="message-reactions-container"]', PIN_INDICATOR: '[name="pin-indicator"]', }; @@ -52,7 +52,7 @@ const SELECTORS_MACOS: selectorContainer = { MESSAGE_GROUP_USER_INDICATOR_IDLE: "~indicator-idle", MESSAGE_GROUP_USER_INDICATOR_OFFLINE: "~indicator-offline", MESSAGE_GROUP_USER_INDICATOR_ONLINE: "~indicator-online", - MESSAGE_REACTION_CONTAINER: "~message-reaction-container", + MESSAGE_REACTION_CONTAINER: "~message-reactions-container", PIN_INDICATOR: "~pin-indicator", }; diff --git a/tests/screenobjects/chats/MessageGroupRemote.ts b/tests/screenobjects/chats/MessageGroupRemote.ts index 53a9c5db62..4513f992a8 100644 --- a/tests/screenobjects/chats/MessageGroupRemote.ts +++ b/tests/screenobjects/chats/MessageGroupRemote.ts @@ -27,7 +27,7 @@ const SELECTORS_WINDOWS: selectorContainer = { MESSAGE_GROUP_USER_INDICATOR_IDLE: '[name="indicator-idle"]', MESSAGE_GROUP_USER_INDICATOR_OFFLINE: '[name="indicator-offline"]', MESSAGE_GROUP_USER_INDICATOR_ONLINE: '[name="indicator-online"]', - MESSAGE_REACTION_CONTAINER: '[name="message-reaction-container"]', + MESSAGE_REACTION_CONTAINER: '[name="message-reactions-container"]', PIN_INDICATOR: '[name="pin-indicator"]', }; @@ -52,7 +52,7 @@ const SELECTORS_MACOS: selectorContainer = { MESSAGE_GROUP_USER_INDICATOR_IDLE: "~indicator-idle", MESSAGE_GROUP_USER_INDICATOR_OFFLINE: "~indicator-offline", MESSAGE_GROUP_USER_INDICATOR_ONLINE: "~indicator-online", - MESSAGE_REACTION_CONTAINER: "~message-reaction-container", + MESSAGE_REACTION_CONTAINER: "~message-reactions-container", PIN_INDICATOR: "~pin-indicator", }; From 0ab418c12a54993de2a5003540c68125826da0ef Mon Sep 17 00:00:00 2001 From: Phill Wisniewski <93608357+phillsatellite@users.noreply.github.com> Date: Wed, 10 Apr 2024 11:20:49 -0400 Subject: [PATCH 2/2] Update ui-automated-tests.yml --- .github/workflows/ui-automated-tests.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/ui-automated-tests.yml b/.github/workflows/ui-automated-tests.yml index 55bbceb329..fea14401fe 100644 --- a/.github/workflows/ui-automated-tests.yml +++ b/.github/workflows/ui-automated-tests.yml @@ -71,7 +71,6 @@ jobs: uses: actions/checkout@v4 with: repository: Satellite-im/Uplink - ref: emoji_reaction_fix - name: Checkout testing directory 🔖 uses: actions/checkout@v4 @@ -146,7 +145,6 @@ jobs: uses: actions/checkout@v4 with: repository: Satellite-im/Uplink - ref: emoji_reaction_fix - name: Checkout testing directory 🔖 uses: actions/checkout@v4