Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple image parameters doesn't work #18

Open
Artmorse opened this issue May 29, 2024 · 2 comments
Open

Multiple image parameters doesn't work #18

Artmorse opened this issue May 29, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@Artmorse
Copy link
Contributor

Describe the bug
Passing multiple image parameters will generate a single image.

To Reproduce

python3 src/cli.py --img='./input-folder/01.jpg' --img='./input-folder/02.jpg'

Expected behavior
I would like to have an output per image input or a message informing the user that this feature is not supported.

@Wabri Wabri added the enhancement New feature or request label May 29, 2024
@Wabri
Copy link
Member

Wabri commented May 29, 2024

ATM it works like that because we simply think on process one image per execution, but maybe we can think about having something like this:

python3 src/cli.py --img='./input-folder/01.jpg,./input-folder/02.jpg'

to be more clear put every images into the --img argument using , or something more human readable, what do you think?

@Artmorse
Copy link
Contributor Author

Yes, I don't have preferences on that point.

My underlying concern is to have better validation. We need the user to know what we're supporting or not.

We can wait for the @BugliL refactoring before digging into this issue though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants