Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tstops should give meaningful error if given duals #1033

Open
elbert5770 opened this issue May 3, 2024 · 1 comment
Open

tstops should give meaningful error if given duals #1033

elbert5770 opened this issue May 3, 2024 · 1 comment

Comments

@elbert5770
Copy link

It's entirely plausible that during an optimization, tstops (e.g. for callbacks) might depend on an optimized variable, and this can lead to a subtle problem with AD. When setting up an ODE, it would be pretty easy and fast to check to see if tstops is of type dual, and if so it should give a meaningful error (other than the generic Float64(Dual...) error), perhaps with instructions of how to extract values from a dual. I can't think of a case where you would want tstops to be a dual.

@ChrisRackauckas
Copy link
Member

Almost missed this one.

Differentiating tstops is used for example in optimal experimental design. There's tests for this because it's a pretty common application that requires learning what the right time points would be.

nd this can lead to a subtle problem with AD

Can you share what this problem is? Maybe handling that problem is the better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants