Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fft and rfft as fit #33

Open
pzimbrod opened this issue Feb 16, 2022 · 0 comments
Open

Use fft and rfft as fit #33

pzimbrod opened this issue Feb 16, 2022 · 0 comments

Comments

@pzimbrod
Copy link
Contributor

#31 introduces Fourier Layer for higher dimensions. For now, rfft has been replaced by fft since it's simpler to implement.

However, rfft can save memory and computation time considerably (~2x), so it should be picked up again.

I think #28 plays a role here as well. If the input is complex, then rfft doesn't make sense. But since we're working with @generated anyway, maybe we can include a check where we can decide whether to use regular or real FFT depending on the input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant