Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resize! missing for MatrixOperator #215

Open
gaurav-arya opened this issue Jul 21, 2023 · 3 comments
Open

resize! missing for MatrixOperator #215

gaurav-arya opened this issue Jul 21, 2023 · 3 comments

Comments

@gaurav-arya
Copy link
Member

Possibly should be modeled after https://github.com/SciML/OrdinaryDiffEq.jl/blob/21a5bbe8d844d889824f94d91948270567fa51d6/src/integrators/integrator_interface.jl#L250
@vpuri3
Copy link
Member

vpuri3 commented Jul 21, 2023

resize is not defined for matrix op. it's only defined for function op and wrappers. it's not defined for abstract matrix either. so if you have a matrix op in there somewhere and you resize, it should error

@vpuri3
Copy link
Member

vpuri3 commented Jul 21, 2023

in the link, J is usually a function op and supports resize functionality.

@vpuri3
Copy link
Member

vpuri3 commented Jul 21, 2023

i think the link is just resizing of the concretized matrix.. this can be accomplished by first resizing and then concretizing. I don't think it needs a special method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vpuri3 @gaurav-arya