rename recovery file #342
Merged
rename recovery file #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Landeers
force-pushed
the
rename-recovery-file
branch
from
e1aecc5 to
379bbd4
Compare
FirelightFlagboy
previously approved these changes
Jan 10, 2024
touilleMan
reviewed
Jan 10, 2024
| @@ -86,7 +86,11 @@ async def export_device(core: LoggedCore) -> tuple[dict[str, Any], int]: | |||
| finally: | |||
| path.unlink() | |||
|
|
|||
| file_name = get_recovery_device_file_name(core.device).replace("parsec-", "resana-secure-", 1) | |||
| file_name = ( | |||
There was a problem hiding this comment.
Add a comment to explain the expected pattern ?
(typically this --unknown- part seems strange, I guess the reason is related to the device label being always unknown in resana, and I'm not sure why the double dash part...)
touilleMan
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #333