-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mp3tag: Update the manifest #14654
mp3tag: Update the manifest #14654
Conversation
All changes look good. Wait for review from human collaborators. mp3tag
|
Did anyone actually test this? The changes for Additionally, running |
@glektarssza Thank you for your detailed report. I did not test the changes, but I did review them, and they looked good. My apologies for any pain caused. I have reverted these changes, and will be more vigilant in the future. |
Hey @rasa, @glektarssza, sorry about this error, I was caught with other things. I'll quickly make another PR, and I hope Rasa can merge it. |
I have made a new PR, #14834 |
Thank you both (@rasa and @FlawlessCasual17) for the quick response and turn around on getting this resolved. Kudos to both of you on that. This is honestly why I love |
Changed the context menu option to use registry files.
Changed the
pre_install
andpre_uninstall
scripts, so the explorer will no longer restart after either.Added a
post_install
script.I have read the Contributing Guide.
NOTE: This PR also updates some
reg
files for VS Code because someone forgot to end them with a blank new line, as seen here in this GitHub Actions log.