Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: XMPlay 4.0 not detected by autoupdate #14678

Open
3 tasks done
mundifex opened this issue Jan 4, 2025 · 3 comments · May be fixed by #14679
Open
3 tasks done

[Bug]: XMPlay 4.0 not detected by autoupdate #14678

mundifex opened this issue Jan 4, 2025 · 3 comments · May be fixed by #14679
Labels

Comments

@mundifex
Copy link
Contributor

mundifex commented Jan 4, 2025

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues/PRs to ensure it has not already been reported or fixed.
  • I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name

xmplay

Expected/Current Behaviour

XMPlay version 4.0 is not being detected using the current configuration of the app's manifest. The app's developer, Un4seen Developments, has uploaded the new version but neglected to update the version number on the main landing page, which is where the manifest currently looks for a version number.

image

Steps to Reproduce

PS> .\bin\checkver.ps1 xmplay
xmplay: 3.8.5

Possible Solution

I will post a PR with an updated manifest that detects new versions in a more stable location on the app's website.

Scoop and Buckets Version

PS> scoop --version
Current Scoop version:
859d1db5 (HEAD -> master, tag: v0.5.2, origin/master, origin/HEAD) chore(release): Bump to version 0.5.2 (#6080)

'main' bucket:
fc7b850ae (HEAD -> master, origin/master, origin/HEAD) gitsign: Update to version 0.12.0

'extras' bucket:
229fd8c7a (HEAD -> master, origin/master, origin/HEAD) treesheets: Update to version 12612114396

'versions' bucket:
c4647680f (HEAD -> master, origin/master, origin/HEAD) zig-dev: Update to version 0.14.0-dev.2598

'java' bucket:
86c58489 (HEAD -> master, origin/master, origin/HEAD) openjdk-ea: Update to version 24-30-ea

'games' bucket:
dc54f463e (HEAD -> master, origin/master, origin/HEAD) unciv: Update to version 4.15.0

Scoop Config

PS> scoop config

PowerShell Version

PS> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.19041.5247
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.5247
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Additional Softwares

No response

@mundifex mundifex added the bug label Jan 4, 2025
@mundifex mundifex linked a pull request Jan 4, 2025 that will close this issue
2 tasks
@feamsr00
Copy link

feamsr00 commented Jan 7, 2025

Hello!

Hate to complicate this for you. I did a check on the url the app is actually pulling version info from.

Url: http://www.un4seen.com/xmpver

Output:

xmplay.exe|4000000|XMPlay 4.0|4000002|XMPlay 4.0.0.2|                                                                   
xmp-7z.dll|1050000|7-Zip archive plugin (rev.5)|                                                                        
xmp-ahx.dll|1202|AHX plugin (rev.18.2)|                                                                                 
xmp-alac.dll|1000300|ALAC plugin (rev.3)|                                                                               
xmp-ape.dll|1000400|Monkey's Audio plugin (rev.4)|                                                                      
xmp-asap.dll|6000300|ASAP plugin (6.0.3)|                                                                               
xmp-asio.dll|1000701|ASIO output plugin (rev.7a)|1000703|ASIO output plugin (rev.7c)|                                   
xmp-cd.dll|1000c00|CD Audio plugin (rev.12)|                                                                            
xmp-coverart.svp|1000901|Cover Art visual plugin (rev.9)|
xmp-delix.dll|905|Delix plugin (rev.9.5)|
xmp-ds.dll|1000500|DirectSound output plugin (rev.5)|1000501|DirectSound output plugin (rev.5a)|
[...]

The format appears to be:
<component>|<stable version integer>|<stable version label>[|<beta version integer>|<beta version label>]

A rough regex, if it helps (the beta tag is only usful for Versions I'd assume):
xmplay\.exe\|([\d.]+)\|(XMPlay [\d.]+)\|

You'd have to munge the label slightly to turn that into a download url, through they follow a predictable format (see https://support.xmplay.com/files.php?id=20)

I see the PR #14679 is pulling from the site. I'm sure that would work too! Until un4seen forgets to update the site again :)

@mundifex
Copy link
Contributor Author

mundifex commented Jan 7, 2025

A much better source of truth for version number -- I've updated my PR to utilize it. Thanks for the suggestion!

Out of curiosity, how did you determine that URL?

@feamsr00
Copy link

feamsr00 commented Jan 8, 2025

Awesome 🚀

Got frustrated enough to shove it behind a proxy (mitmproxy) heh.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants