Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excavator action is not continuing to update other manifests after failing. #32

Open
sedlund opened this issue Feb 26, 2023 · 1 comment
Open

Excavator action is not continuing to update other manifests after failing. #32

sedlund opened this issue Feb 26, 2023 · 1 comment

Comments

@sedlund
Copy link

sedlund commented Feb 26, 2023

The Excavator workflow is not continuing on error and failing to update all the Scoop buckets.

Currently Extras bucket is stuck on librewolf ScoopInstaller/Extras#10591
Main is stuck on pnpm https://github.com/ScoopInstaller/Main/actions/runs/4273331999/jobs/7439175044#step:3:584
Versions is stuck on matrix https://github.com/ScoopInstaller/Versions/actions/runs/4273354246/jobs/7439213141#step:3:405

Any manifest that is alphabetically after the failed manifest will not get updated by the action.

I dont think

$Global:ErrorActionPreference = 'Continue'

Is getting scoped into

GithubActions/src/Action/Scheduled.psm1

Line 31 in 23a63d8

& (Join-Path $BINARIES_FOLDER 'auto-pr.ps1') @params

But I don't know PS...
@sedlund sedlund mentioned this issue Feb 26, 2023
Closed
3 tasks
sedlund added a commit to sedlund/Scoop that referenced this issue Feb 27, 2023
@sedlund
fix(checkver) use Start-Job for manifest script to not to exit on break
d828c69 
Invoke-Command will exit the parent process if a manifest script issues
a break command.  Use Start-Job to resolve this.

Fixes ScoopInstaller/GithubActions#32
sedlund added a commit to sedlund/Scoop that referenced this issue Feb 27, 2023
@sedlund
fix(checkver) use Start-Job for manifest script to not to exit on break
7ee2366 
Invoke-Command will exit the parent process if a manifest script issues
a break command.  Use Start-Job to resolve this.

Fixes ScoopInstaller/GithubActions#32
@sedlund sedlund mentioned this issue Feb 27, 2023
Closed
5 tasks
@rashil2000
Copy link
Member

rashil2000 commented Feb 27, 2023 •
edited
Loading

Damn, thanks for bringing this to our notice, @sedlund! Much appreciated!

@rashil2000 rashil2000 mentioned this issue Feb 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sedlund @rashil2000