beyondcompare-np:Add version 5.x.y.z #385
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All changes look good. Wait for review from human collaborators. beyondcompare-np
|
pohlymorph
force-pushed
the
add-manifest-beyondcompare5
branch
2 times, most recently
from
44df9cc to
f75ad98
Compare
pohlymorph
force-pushed
the
add-manifest-beyondcompare5
branch
3 times, most recently
from
2c9adcd to
bc5c2bb
Compare
|
/verify |
|
All changes look good. Wait for review from human collaborators. beyondcompare-np
|
pohlymorph
force-pushed
the
add-manifest-beyondcompare5
branch
from
4d43a24 to
3e6982f
Compare
HUMORCE
reviewed
Jan 10, 2025
- commit suggestion, review finding Co-authored-by: HUMORCE <[email protected]>
- remove registry entries left using the installer in 'non-portable' mode
|
/verify |
|
All changes look good. Wait for review from human collaborators. beyondcompare-np
|
niheaven
requested changes
Jan 11, 2025
- address review finding Co-authored-by: Hsiao-nan Cheung <[email protected]>
- address review findings - ScoopInstaller#385 (comment) - ScoopInstaller#385 (comment) - ScoopInstaller#385 (comment) Co-authored-by: Hsiao-nan Cheung <[email protected]>
pohlymorph
force-pushed
the
add-manifest-beyondcompare5
branch
from
49cbbfb to
b132c40
Compare
- revert 5dce899 - use uninstaller - use 'reg delete' recursively to remove installation entry showing up in 'Apps & features' otherwise
|
/verify |
|
All changes look good. Wait for review from human collaborators. beyondcompare-np
|
|
The context menu addition should be done via its installer instead of an extra script/registry file, for non-portable apps. unless it cannot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a non-portable installation of Beyond Compare version 5.x.y.z:
Relates to ScoopInstaller/Extras#13663
Relates to PR ScoopInstaller/Extras#14026
see discussion beyondcompare: Add version 5.x.y.z Extras#14026 (comment)
see discussion beyondcompare: Add version 5.x.y.z Extras#14026 (comment)
I have read the Contributing Guide.
FYI @niheaven, @HUMORCE