Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Migrate the messages page to SSR #110

Open
pm3512 opened this issue Nov 5, 2022 · 0 comments
Open

[Feature] Migrate the messages page to SSR #110

pm3512 opened this issue Nov 5, 2022 · 0 comments
Assignees
@pm3512
Labels
enhancement New feature or request performance Improving performance

Comments

@pm3512
Copy link
Contributor

pm3512 commented Nov 5, 2022

Description

The messages page (pages/messages.tsx) currently get the message info inside useEffect(). To use SSR, the requests needs to be extracted into the function getServerSideProps(), which would pass the messages and their status (seen/not seen) to the page as a prop.

Designs

No response
@pm3512 pm3512 added the enhancement New feature or request label Nov 5, 2022
@gramliu gramliu added the performance Improving performance label Nov 5, 2022
@pm3512 pm3512 self-assigned this Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pm3512 pm3512

Labels
enhancement New feature or request performance Improving performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gramliu @pm3512