Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache path is declared but never used in the code #898

Open
clemlesne opened this issue Jan 17, 2025 · 1 comment
Open

Cache path is declared but never used in the code #898

clemlesne opened this issue Jan 17, 2025 · 1 comment
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@clemlesne
Copy link

Describe the bug

The documentation describes a parameter cache_path to multiple graph configurations. But it is never used in the code.

Expected behavior

The library is caching something, for example, URLs and prompts.

Desktop:

  • Version 1.36.0
Copy link

dosubot bot commented Jan 17, 2025

Hey @clemlesne! I'm here to help you out with any bugs or questions you have. I'm a bot designed to assist you while waiting for a human maintainer. Let's tackle this together!

The cache_path parameter is indeed mentioned in the documentation and is intended to specify the path where fetched content will be cached. This allows for storing content locally to improve efficiency by reducing redundant network requests [1][2]. However, it seems that the actual implementation of caching logic using cache_path might be missing or not fully integrated into the codebase, as noted in your observation.

The cache_path is referenced in the FetchNodeLevelK class, where it is initialized in the constructor, but there is no detailed information on how it is utilized for caching operations [2]. Additionally, there are examples demonstrating how to set the cache_path parameter in node configurations, such as in the DescriptionNode [3].

To address this issue, you might need to review the codebase to ensure that the caching logic is implemented and that cache_path is actively used in the relevant classes or methods.

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other

@dosubot dosubot bot added documentation Improvements or additions to documentation bug Something isn't working labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant