New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove magic IP addess #7

Open

psgivens opened this issue Oct 11, 2018 · 0 comments

psgivens commented Oct 11, 2018

invoicer-chapter3/.circleci/config.yml

Line 48 in 37da2ca

-t http://172.17.0.2:8080/ || \

Instead of using a magic IP address, consider using a docker network and named containers, like this:
docker network create --driver bridge secdevops-net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment