Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let form_beliefs use external regressors #116

Open
Flix6x opened this issue Oct 21, 2022 · 0 comments
Open

Let form_beliefs use external regressors #116

Flix6x opened this issue Oct 21, 2022 · 0 comments

Comments

@Flix6x
Copy link
Collaborator

Flix6x commented Oct 21, 2022

Originally posted by @Flix6x in #50 (comment):

It can be done by passing an extra X to the fit function, for example, like this:

X=df.loc[:, df.columns != "event_value"]

Here, I'm assuming the external regressors are given as additional columns in the BeliefsDataFrame. They need to be passed through correctly, though. And also tested properly. NB Testing it with sktime's naive forecaster will just lead to the forecaster ignoring X.

Originally posted by @nhoening in #50 (comment):

The X above is already added in PR #50. A little comment would help. Also add an optional parameter to form_beliefs, e.g. "X_column_names", and check for cases where columns in X would be bad to include.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant