-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[javascript] Support for tap events based on touch #15260
base: trunk
Are you sure you want to change the base?
Conversation
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement
Description
Added support for tap events in Selenium's JavaScript atoms.
Introduced
tap
function inwebdriver.atoms.inputs
for touchscreen interactions.Updated
BUILD.bazel
to include a new closure fragment fortap
.Modified
events.js
to handleinitTouchEvent
differently for iOS.Changes walkthrough 📝
events.js
Update `initTouchEvent` handling for iOS compatibility
javascript/atoms/events.js
initTouchEvent
handling for non-iOS devices.initTouchEvent
.inputs.js
Export `tap` function in `webdriver.atoms.inputs`
javascript/webdriver/atoms/exports/inputs.js
tap
function for external use.action.js
Add `tap` function to inject tap actions
javascript/webdriver/atoms/inject/action.js
tap
function to inject tap actions on elements.tap
function with JSDoc comments.inputs.js
Add `tap` function for touchscreen interactions
javascript/webdriver/atoms/inputs.js
tap
function for touchscreen interactions.bot.Touchscreen
for touch-based actions.BUILD.bazel
Add closure fragment for `tap` in BUILD.bazel
javascript/webdriver/atoms/inject/BUILD.bazel
tap
function.tap
to theaction
module dependencies.