[java] simplify strings processing #15309
Open
+4
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
This pull request includes several changes to improve code readability and consistency in the Selenium project. The most important changes involve replacing deprecated string methods and updating header content type handling.
Improvements to code readability and consistency:
java/src/dev/selenium/tools/modules/ModuleGenerator.java
: Simplified the error message concatenation by removing unnecessarynew String
conversion.java/src/org/openqa/selenium/Cookie.java
: Replaced("".equals(path))
withpath.isEmpty()
for better readability.java/src/org/openqa/selenium/Platform.java
: Replaced("".equals(matcher))
withmatcher.isEmpty()
for better readability.java/src/org/openqa/selenium/remote/codec/AbstractHttpCommandCodec.java
: Removed unnecessarytoString()
call onJSON_UTF_8
when setting the content type header.Motivation and Context
Types of changes
Checklist
PR Type
Enhancement
Description
Simplified string operations for better readability.
Replaced deprecated or redundant string methods.
Improved header content type handling in HTTP requests.
Enhanced error message concatenation in module processing.
Changes walkthrough 📝
ModuleGenerator.java
Simplified error message concatenation logic
java/src/dev/selenium/tools/modules/ModuleGenerator.java
new String
conversion.Cookie.java
Improved readability in cookie string representation
java/src/org/openqa/selenium/Cookie.java
("".equals(path))
withpath.isEmpty()
.Platform.java
Improved OS name matching readability
java/src/org/openqa/selenium/Platform.java
("".equals(matcher))
withmatcher.isEmpty()
.AbstractHttpCommandCodec.java
Simplified header content type handling
java/src/org/openqa/selenium/remote/codec/AbstractHttpCommandCodec.java
toString()
call onJSON_UTF_8
.