Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devcontainer.json #15344

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

SAGlobalBhavana
Copy link

@SAGlobalBhavana SAGlobalBhavana commented Feb 27, 2025

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

configuration changes


Description

  • Updated the devcontainer.json file for configuration.

  • Fixed an issue with duplicate dockerfile entries.


Changes walkthrough 📝

Relevant files
Configuration changes
devcontainer.json
Fix duplicate `dockerfile` entry in configuration               

.devcontainer/devcontainer.json

  • Removed duplicate dockerfile entry in the build section.
  • Ensured proper configuration for the devcontainer setup.
  • +1/-0     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @CLAassistant
    Copy link

    CLA assistant check
    Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
    You have signed the CLA already but the status is still pending? Let us recheck it.

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Invalid JSON

    The JSON file has duplicate dockerfile keys in the build object which makes it invalid and will cause parsing errors

    "dockerfile": "../scripts/dev-image/Dockerfile"
     "dockerfile": "../scripts/dev-image/Dockerfile"

    Copy link
    Contributor

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Remove duplicate JSON property

    Remove the duplicate dockerfile property in the build section as it causes a
    JSON syntax error and only one path can be specified.

    .devcontainer/devcontainer.json [5-8]

     "build": {
    -  "dockerfile": "../scripts/dev-image/Dockerfile"
       "dockerfile": "../scripts/dev-image/Dockerfile"
     },
    • Apply this suggestion
    Suggestion importance[1-10]: 10

    __

    Why: The duplicate 'dockerfile' property in the build section creates a JSON syntax error that would break the devcontainer configuration. Removing it is critical for the file to work properly.

    High
    • More

    @SAGlobalBhavana
    Copy link
    Author

    Updated the logic

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants