-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.0.0 release #11
Comments
Let's see how SemanticMediaWiki/SemanticMediaWiki#1969 plays out. |
👍
FYI @oetterer |
I opened PR's for I would also like to add the To maybe get a better understanding, here is the data structure I would like to have: -- call would look something like
local result = mw.smw.ask{'[[Modification date::+]]', 'Modification date#-F[F j, Y]=mdate', 'Last editor is=editor', 'limit=2'}
-- and _result_ would be
result = {
{
MainLabel = 'Main Page',
mdate = 'March 4, 2015',
editor = 'User:Admin'
},
{
MainLabel = 'User:Admin',
mdate = 'November 13, 2016',
editor = 'User:Admin'
}
} Again, I am not looking to replace |
I understand the thought process, so 👍 Maybe when amending the |
@oetterer It will be very nice if you could work on this for the upcoming release. Thanks a lot in advance! |
He already did and I reorged the docs https://github.com/SemanticMediaWiki/SemanticScribunto/tree/master/docs. |
Oops, pardon me then. Sorry. Looking forward to a realease now? |
My last suggestion for augmentation is on GitHub (see PR #24). Maybe this could be added before the 1.0 release? |
It is looking good (without me being in a driver seat 👍 ) and in case @oetterer isn't too exhausted maybe creating some examples [0] should help others as well and can work as litmus test that what we believe to function does so on-wiki. @kghbln After #24 got merged maybe a quick look in the [1] to avoid any obvious blunders. @oetterer Thanks for the time investment especially on maintaining appropriate tests which sometimes may seem daunting, yet to be inevitable when creating a software package. [0] https://sandbox.semantic-mediawiki.org/wiki/Cat%C3%A9gorie:Semantic_Scribunto_example |
Some feedback from @matthew-a-thompson @cicalese on the added functionality and documentation [0] would be much appreciated before the release. [0] https://github.com/SemanticMediaWiki/SemanticScribunto/tree/master/docs |
I'm a little bit uncertain on how and where to add my name to this project. I'm willing to take responsibility and remain as maintainer but I don't want to take any unsolicited credit. |
Hopefully I find the time next week. But I have this on my todo list. |
The updated page for getQueryResult looks good. There's only one thing I can think of to potentially add as a clarification, and that is: the elements of "results" (queryResult.results in the sample code) are 1-indexed. This is so that, as the sample code shows, the results can easily be iterated over in order by the pairs function. However, any other table contents that came from integer-keyed PHP arrays are likely to be 0-indexed instead. |
Good example for an integration test. |
Added a first set of examples. I somehow found it a good idea to start with a complex set of pages and modules :( However: on my todo is
more suggestions? |
Having finished https://sandbox.semantic-mediawiki.org/wiki/Semantic_Scribunto_example, and https://sandbox.semantic-mediawiki.org/wiki/Module:Smw and also augmented https://sandbox.semantic-mediawiki.org/wiki/Module:SSC_base, and https://sandbox.semantic-mediawiki.org/wiki/Module:Person/class I would like to propose to check "Examples on sandbox" in the first post. Unless of course, there are more suggestions? |
Wow, all this great work. I guess it is about time to get the extension to the public - yes?!. |
I'd say this is exemplary and should be sufficient for users who want to find some anchor points and interaction from a practical perspective with this extension. Thanks for the dedication on the test part.
Not for the 1.0 release but maybe as a feature for a next release is to track those
Yes. (Docs are covered, tests are available, and as always you can push another release anytime) |
@mwjames We still need the RELEASE NOTES we do not have at all yet. Just creating a 1.0.0 - Initial public release is perhaps not good enough. I believe that you have the best idea on what has to be in there. I can do the rest once it is there. |
https://github.com/SemanticMediaWiki/SemanticScribunto/blob/master/RELEASE-NOTES.md |
Done :) |
The text was updated successfully, but these errors were encountered: