Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holidays display like events #142

Open
Serhioromano opened this issue Oct 2, 2013 · 3 comments
Open

Holidays display like events #142

Serhioromano opened this issue Oct 2, 2013 · 3 comments

Comments

@Serhioromano
Copy link
Owner

I have project recently on UN site. They have many holidays.

http://www.un.org/en/events/observances/days.shtml

Sometimes up to 5 in a day. The wanted calendar wшер those events. But not like it is implemented currently where holiday only highlight day with different color. They wanted those holidays be like any other event.

I think this is important feature.

We need init parameter holiday class for special color if you want and display holidays like any other event.

And this is very easy I think. because now we do not need to go through holidays and we already have function to get events list from-to. This method may also look for holidays in that period and merge them into returned events array.

@mlocati
Copy link
Contributor

mlocati commented Oct 2, 2013

IMHO that would be optional. Someone (like me) may not want to have their own events and the holidays events mixed together...

@Serhioromano
Copy link
Owner Author

mlocati.imho == true

@mlocati
Copy link
Contributor

mlocati commented Oct 2, 2013

We could add a boolean option like holidays_as_events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants