Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add points for people submitting code reviews? #33

Open
earlduque opened this issue Oct 11, 2024 · 2 comments
Open

Add points for people submitting code reviews? #33

earlduque opened this issue Oct 11, 2024 · 2 comments

Comments

@earlduque
Copy link
Contributor

Maintainers already get points for either closing a pull request or merging them in, and this has historically been enough because most of time a pull review is only ever looked at by one maintainer.

But should we make it so reviews also get a point for situations like #32 where a bunch of reviewers submitted a review? Having a point for submitting review would solve this situation of reviewers-that-aren't-the-closer/merger get credit, but then our normal reviewer-and-closer/merger situation means people will be doubling up on maintainer points.

@wiz0floyd
Copy link

Sounds good to me

@Lacah
Copy link
Contributor

Lacah commented Nov 1, 2024

In prinicple sounds good to me too, but I am concerned this would be used to "game" the leaderboard. By default, anyone can add reviews, so one could just approve "everything everywhere all at once" without any substance to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants