Refactoring

[h4llow3En]

This is a ticket to keep track of the ongoing refactoring

Roadmap:

• edit configuration
• Make sure on install that python3.8+ is used
• Select quality
• save preferred quality in config
• Make it installable via pip
• Save username
• Save passwords in keychain
• Update readme
• Readd support for multiple languages
• Add changelog
• Readd support for streamlock

Testing:

• Windows
• Linux
• Mac

[ShadetHeart]

Quality selection is good, as the highest quality option uses an insane (and for most people unnecessary) amount of bandwidth.

In regard to audio:
AoD usually offers japanese audio with subtitles
In addition, sometimes german audio is available as well.
Both use a different video stream with their own audio track. Putting both audio options into a video container is possible. But unfortunately the subtitles are hardsubbed and not a seperate file as one would find it e.g. on a DVD. So the option of switching them 'on' and 'off' inside of a video container unfortunately is not available.

I would not focus on the streamlock support. In case a small percentage of series/movies still uses it, one can simple use the old script.

[h4llow3En]

Thanks for your input.
What do you think about "scanning" which languages are available and if there are both the user is asked which one he prefers? Once for animeurl of course not for every episode.

Same would be my suggestion with the quality settinfs

[rennerdo30]

First of all, Thanks for this great tool.
I would like to add some input on the topic of mixing sub & dub versions.

In my eyes it would be really helpful if the user had the possibility to generate a single mkv file, containing both video streams.
This should be possible using ffmpeg.
https://video.stackexchange.com/questions/12867/combine-multiple-videos-as-separate-streams-in-one-mkv-file

Another possible solution would be a config option, to download both file at once. So the user can have the sub and dub version.

[ShadetHeart]

Thanks for your input.
What do you think about "scanning" which languages are available and if there are both the user is asked which one he prefers? Once for animeurl of course not for every episode.

Same would be my suggestion with the quality settinfs

Sounds good, but I would prefer an option which requires less input. Best case scenario would be a automatic selection based on preferences, with a prompt if these preferences are not set.

But we should think about this once the refactored script features all the basic functionalities.

[h4llow3En]

@ShadetHeart I finally got some more time to work on the refactoring.
Another Question. In the original script the quality settings were ordered from highest to lowest.
In my opinion we should sort them the other way. Because I found some older animes that won't have six different qualities.

[h4llow3En]

Quality selection now chooses the highest available if max settings are not met

[h4llow3En]

@ShadetHeart refactoring is done. Are you able to test this on windows? I already tested it on Mac and Linux (Desktop and Server)

Otherwise we could release version 1.0.0

[h4llow3En]

@SpyrexDE did you test it? Could we close this issue and release version 1.0.0?

[ShadetHeart]

@h4llow3En I can do some Windows testing now.
Keyring does not seem to work on my installation.

AoDDownloader config list

File "c:\users\xxx\appdata\local\programs\python\python39\lib\site-packages\AoDDownloader\cli.py", line 94, in list
downloader = create_downloader()
TypeError: create_downloader() missing 1 required positional argument: 'password'

I already ran login() and entered my credentials.

[h4llow3En]

@ShadetHeart That error does not seem to be associated with the KeyChain. @SpyrexDE you have done something with this function. Any Idea? I currently have very limited time to look into that