Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does benchmark have to be upstream of generator? #42

Closed
rpgoldman opened this issue Aug 2, 2024 · 2 comments
Closed

Does benchmark have to be upstream of generator? #42

rpgoldman opened this issue Aug 2, 2024 · 2 comments

Comments

@rpgoldman
Copy link
Contributor

CCL's compiler doesn't like it that benchmark is defined (in toolkit.lisp) before generator.lisp is loaded. It says this:

Compiler warnings for "home:lisp;shop;jenkins;ext;random-state;toolkit.lisp.newest" :
;   In BENCHMARK: INLINE declaration for unknown function ENSURE-GENERATOR
;   In BENCHMARK: Unknown type (FUNCTION (GENERATOR) T), declaration ignored

I would like to pull the two benchmark functions out and put them in "histogram.lisp", since they are not called so only need to be defined by the time "random-state" is completely loaded.

If you are ok with that, I'll send another PR. But please let me know if there is some reason I should not do this.

@rpgoldman
Copy link
Contributor Author

See #43

@Shinmera
Copy link
Owner

Shinmera commented Aug 3, 2024

nah, seems fine.

@Shinmera Shinmera closed this as completed Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants