Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up Validation object #230

Open
HawaiianSpork opened this issue Jun 13, 2021 · 0 comments
Open

Clean-up Validation object #230

HawaiianSpork opened this issue Jun 13, 2021 · 0 comments
Labels
enhancement New feature or request
Milestone
2.0

Comments

@HawaiianSpork
Copy link
Contributor

  • BaleenType.validate should return a Validation rather than a Sequence of ValidationResult. This will make it an O(1) operation to figure out wether the results are valid and other quick operations.
  • No need to expose the Context, Data or DataTrace from the Validation object.
  • Remove Context, it is just a container for a DataTrace + Data. We don't need another concept to confuse users.
@HawaiianSpork HawaiianSpork added the enhancement New feature or request label Jun 13, 2021
@HawaiianSpork HawaiianSpork added this to the 2.0 milestone Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@HawaiianSpork