Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Add flag to make theme push idempotent #2699

Closed
jeffreyguenther opened this issue Aug 24, 2023 · 16 comments · May be fixed by #5309
Closed

[Feature]: Add flag to make theme push idempotent #2699

jeffreyguenther opened this issue Aug 24, 2023 · 16 comments · May be fixed by #5309
Labels
Area: @shopify/theme @shopify/theme package issues no-issue-activity Type: Enhancement New feature or request

Comments

@jeffreyguenther
Copy link

What area(s) will this request affect?

Theme

What type of change do you want to see?

New feature

Overview

Would it be possible to add a flag that makes theme push idempotent?

Given a theme name, it would only create a single theme with that name.

Right now, if the --unpublished flag is passed, it will create multiple themes with the same name. Without --unpublished, it will error if the theme isn't created.

What I'd like is the ability to run theme push --theme jeff/feature-branch multiple times and only have a single theme created.

Motivation

To support PR reopening in a GitHub, we need the ability to push to a theme named after a branch multiple times and have only a single theme created.

In the pre-1.0 release of Shopkeeper I had to add a create command in order to make this possible.

I walk through how someone can use GitHub Actions to write workflows to provide a CI/CD experience for Shopify like you might have with other tools like Heroku or Vercel's branch previews.
@jeffreyguenther jeffreyguenther added the Type: Enhancement New feature or request label Aug 24, 2023
@isaacroldan isaacroldan added the Area: @shopify/theme @shopify/theme package issues label Aug 24, 2023
@github-actions
Copy link
Contributor

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

@jeffreyguenther
Copy link
Author

Not sure how to keep this open... The problem is a bit of a tricky one in terms of the existing command and flags. @isaacroldan do you have a sense of whether we should pursue a fix for this in the CLI or if I should continue to handle it with my plugin?

I'm happy to contribute a change, but would need guidance to align it with Shopify's vision.

@isaacroldan
Copy link
Contributor

Hi @jeffreyguenther, thanks for the proposal. @karreiro or @mgmanzella would be better to answer you this question :)

@knjshimi
Copy link

+1 This would be a great thing!

@github-actions
Copy link
Contributor

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

@knjshimi
Copy link

knjshimi commented Nov 3, 2023

Still relevant

@github-actions GitHub Actions
Copy link
Contributor

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

@knjshimi
Copy link

Still relevant

@github-actions GitHub Actions
Copy link
Contributor

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

@github-actions github-actions bot closed this as completed Feb 7, 2024
@charlespwd
Copy link
Contributor

Still useful.

@charlespwd charlespwd reopened this Feb 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

@ascheucher-shopify-partner
Copy link

This issue ist still relevant and always should have been the default behavior.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 5, 2024

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

@charlespwd
Copy link
Contributor

Still useful.

@github-actions GitHub Actions
Copy link
Contributor

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

This was referenced Jan 28, 2025
Open
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: @shopify/theme @shopify/theme package issues no-issue-activity Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add flag to allow —unpublished to reuse theme names TheBeyondGroup/cli
6 participants
@karreiro @jeffreyguenther @isaacroldan @charlespwd @knjshimi @ascheucher-shopify-partner