Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump action from Node12 to Node16 #13

Merged
merged 3 commits into from
Nov 19, 2023
Merged

Conversation

devenes
Copy link
Contributor

@devenes devenes commented Nov 8, 2022

Node 12 has an end of life on April 30, 2022.

This PR updates the default runtime to node16, rather then node12.

Node.js 12 actions are deprecated. For more information see: github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12.

This is supported on all Actions Runners v2.285.0 or later.

Signed-off-by: Enes [email protected]

Node 12 has an end of life on April 30, 2022.

This PR updates the default runtime to [node16](https://github.blog/changelog/2021-12-10-github-actions-github-hosted-runners-now-run-node-js-16-by-default/), rather then node12. 

This is supported on all Actions Runners v2.285.0 or later.

Signed-off-by: Enes <[email protected]>
Node 12 has an end of life on April 30, 2022.

This PR updates the default runtime to [node16](https://github.blog/changelog/2021-12-10-github-actions-github-hosted-runners-now-run-node-js-16-by-default/), rather then node12.

This is supported on all Actions Runners v2.285.0 or later.

Signed-off-by: Enes <[email protected]>
@alex-page
Copy link
Member

Yo @lavoiesl do you mind if I ship this PR? It looks good to me and will stop GH Actions from force updating the action to run on Node 16.

Copy link
Collaborator

@lavoiesl lavoiesl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to do what you want with it, I'm not actively using this action, so I don't have a continuous way of testing it.

@alex-page alex-page merged commit c77c9b3 into Shopify:master Nov 19, 2023
@devenes devenes deleted the patch-1 branch November 20, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants