Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action fails on "new-ish" macOS releases #19

Open
MichalSalon opened this issue Feb 28, 2024 · 1 comment
Open

Action fails on "new-ish" macOS releases #19

MichalSalon opened this issue Feb 28, 2024 · 1 comment

Comments

@MichalSalon
Copy link

MichalSalon commented Feb 28, 2024

Hi,

this action fails on new-ish (latest 3) MacOS releases due to outdated dependencies.

My issue is specifically caused by old version of macos-release lib: https://github.com/Shopify/upload-to-release/blob/master/node_modules/macos-release/index.js failing for macos-latest:

2024-02-28T14:20:04.7511480Z ##[group]Run Shopify/upload-to-release@c77c9b3e5d288adaef98a7007bf92340ec6ce03b
2024-02-28T14:20:04.7512380Z with:
2024-02-28T14:20:04.7513430Z   name: XYZ-darwin-arm64
2024-02-28T14:20:04.7513920Z   path: ./bin/XYZ-darwin-arm64
2024-02-28T14:20:04.7514710Z   repo-token: ***
2024-02-28T14:20:04.7515170Z   content-type: application/octet-stream
2024-02-28T14:20:04.7515710Z ##[endgroup]
2024-02-28T14:20:05.0146320Z /Users/runner/work/_actions/Shopify/upload-to-release/c77c9b3e5d288adaef98a7007bf92340ec6ce03b/node_modules/universal-user-agent/index.js:13
2024-02-28T14:20:05.0149100Z     throw error
2024-02-28T14:20:05.0170380Z     ^
2024-02-28T14:20:05.0174120Z 
2024-02-28T14:20:05.0177240Z TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))
2024-02-28T14:20:05.0181100Z     at macosRelease (/Users/runner/work/_actions/Shopify/upload-to-release/c77c9b3e5d288adaef98a7007bf92340ec6ce03b/node_modules/macos-release/index.js:26:26)
2024-02-28T14:20:05.0185340Z     at osName (/Users/runner/work/_actions/Shopify/upload-to-release/c77c9b3e5d288adaef98a7007bf92340ec6ce03b/node_modules/os-name/index.js:21:18)
2024-02-28T14:20:05.0189820Z     at getUserAgentNode (/Users/runner/work/_actions/Shopify/upload-to-release/c77c9b3e5d288adaef98a7007bf92340ec6ce03b/node_modules/universal-user-agent/index.js:7:53)
2024-02-28T14:20:05.0194270Z     at Object.<anonymous> (/Users/runner/work/_actions/Shopify/upload-to-release/c77c9b3e5d288adaef98a7007bf92340ec6ce03b/node_modules/@octokit/graphql/index.js:5:52)
2024-02-28T14:20:05.0197680Z     at Module._compile (node:internal/modules/cjs/loader:1198:14)
2024-02-28T14:20:05.0200160Z     at Object.Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
2024-02-28T14:20:05.0202720Z     at Module.load (node:internal/modules/cjs/loader:1076:32)
2024-02-28T14:20:05.0205180Z     at Function.Module._load (node:internal/modules/cjs/loader:911:12)
2024-02-28T14:20:05.0209890Z     at Module.require (node:internal/modules/cjs/loader:1100:19)
2024-02-28T14:20:05.0213310Z     at require (node:internal/modules/cjs/helpers:119:18)
@lilith
Copy link

lilith commented Jan 21, 2025

Seeing the same:

/Users/runner/work/_actions/Shopify/upload-to-release/master/node_modules/universal-user-agent/index.js:13
    throw error
    ^

TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))
    at macosRelease (/Users/runner/work/_actions/Shopify/upload-to-release/master/node_modules/macos-release/index.js:26:26)
    at osName (/Users/runner/work/_actions/Shopify/upload-to-release/master/node_modules/os-name/index.js:21:18)
    at getUserAgentNode (/Users/runner/work/_actions/Shopify/upload-to-release/master/node_modules/universal-user-agent/index.js:7:53)
    at Object.<anonymous> (/Users/runner/work/_actions/Shopify/upload-to-release/master/node_modules/@octokit/graphql/index.js:5:52)
    at Module._compile (node:internal/modules/cjs/loader:1469:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1[54](https://github.com/imazen/imageflow/actions/runs/12885889622/job/35925296763#step:27:55)8:10)
    at Module.load (node:internal/modules/cjs/loader:1288:32)
    at Module._load (node:internal/modules/cjs/loader:1104:12)
    at Module.require (node:internal/modules/cjs/loader:1311:19)
    at require (node:internal/modules/helpers:179:18)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants