-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert model attributes to snake_case #43
Comments
can you assign this to me? @lucianghinda interested to work :) |
@obaidashfaq20 sure Thank you very much for wanting to work on this. Please do each change in one PR eg. Author should be one PR, Book should be one PR, Course should be one PR. Will be amazing (but not exactly required) if you manage to write some tests in Minitest. It is not required as the test coverage in this project is low. But I plan to start adding more tests as I find more time. In case you want to add some tests here is a plan.
The test could be as simple as: class AuthorTest < ActiveSupport::TestCase
test "fixture is valid" do
author = authors(:one)
assert_predicate author, :valid?
assert_empty author.errors
end
end
|
Thanks for the opportunity, I am glad found this project with such responsive members. |
@lucianghinda I am planning to add the test suite for the complete project in a separate PR if that's okay?, in modular approach models, controllers, and features. For now, I just created the pull requests with desired changes only. Will update you on the test progress |
Each of the following needs to be changed in at least 5 places:
app/avo/resources
)After changing those please run something like:
grep -rin twitterUrl .
in the root of the app to check iftwitterUrl
still existsor
rg -F "twitterUrl" .
Author
Change
twitterUrl
totwitter_url
in DBgithubUrl
togithub_url
siteUrl
towebsite_url
Book
getBookOnAmazonUrl
toamazon_url
getBookOnSiteTitle
towebsite_title
getBookOnSiteUrl
towebsite_url
Course
courseSiteTitle
towebsite_title
courseSiteUrl
towebsite_url
The text was updated successfully, but these errors were encountered: