Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python's in-built logging module #29

Open
umute97 opened this issue Sep 19, 2022 · 3 comments
Open

Use python's in-built logging module #29

umute97 opened this issue Sep 19, 2022 · 3 comments

Comments

@umute97
Copy link

umute97 commented Sep 19, 2022

More of a feature request: At the moment, warnings and errors are printed out via print() functions. I suggest using the logging module to filter feedback from pylandau based on a verbosity level.

This happens on the latest release pylandau==2.2.1.

Example

WARNING: sigma > 100 * eta can lead to oszillations. Check result.

@cbespin
Copy link
Collaborator

cbespin commented Jan 23, 2023

Thanks for the suggestion! I completely agree, but have very limited time currently for support. Since the fix is minimal, could you provide a pull request?

@guigoruiz1
Copy link
Contributor

I second that. The warning is quite annoying and I'd like to be able to silence it

@cbespin
Copy link
Collaborator

cbespin commented Aug 22, 2024

Sorry, that I did not come to this sooner. I will deal with it probably next week if nobody opens a merge request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants