Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata to examples that output Signal K numeric values #322

Open
joelkoz opened this issue Dec 15, 2020 · 1 comment
Open

Add metadata to examples that output Signal K numeric values #322

joelkoz opened this issue Dec 15, 2020 · 1 comment

Comments

@joelkoz
Copy link
Collaborator

joelkoz commented Dec 15, 2020

The Signal K specification states that numeric values should have a "units" defined. Review our examples, and if any output a number on a Signal K path that is not already in the specification, add the new SKMetadata to the example to define the units.

@joelkoz joelkoz changed the title Add metadata to examples that SKOutput numbers Add metadata to examples that output Signal K numeric values Dec 15, 2020
@ba58smith
Copy link
Collaborator

signalk_output.cpp contains this debug warning message: WARNING - No metadata for %s. Numeric values should specify units. But that's true only if the path isn't already in the Signal K specification. Maybe this warning should indicate that? Something like WARNING - No metadata for %s. Numeric values should specify units, unless this SK Path is already in the Signal K Specification.?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants