Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove large inline methods from headers #339

Open
joelkoz opened this issue Dec 21, 2020 · 1 comment
Open

Remove large inline methods from headers #339

joelkoz opened this issue Dec 21, 2020 · 1 comment
Assignees

Comments

@joelkoz
Copy link
Collaborator

joelkoz commented Dec 21, 2020

In an attempt to minimize the memory footprint of SensESP, a review of memory generation has revealed several inline pieces of code that causes large hunks of memory to be used for mostly redundant code blocks. Audit the header files, and eliminate or move as many inline methods as possible to the .cpp file. The biggest offenders an initial memory inspect has uncovered:

  • SensESPApp::connect_1to1_h()
  • SKOutput::as_signalk()
@joelkoz joelkoz self-assigned this Dec 21, 2020
@ba58smith
Copy link
Collaborator

See @mairas comments in PR #365 before you do this. His findings seem to be contrary to what's stated above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants