Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup following move of orientation to external library #403

Closed
BjarneBitscrambler opened this issue Apr 7, 2021 · 1 comment · Fixed by #405
Closed

Cleanup following move of orientation to external library #403

BjarneBitscrambler opened this issue Apr 7, 2021 · 1 comment · Fixed by #405

Comments

@BjarneBitscrambler
Copy link
Contributor

The remnants of the old orientation code, which was left behind when PR #349 was abandoned, has caused compile errors recently when AdaFruit changed their FXOS/FXAS library. @mairas has removed some of these remnants (in #402), but there still remains the AdaFruit AHRS (Attitude and Heading Reference System) library in library.json and platform.ini This library is unneeded by any current sensors AFAIK, and can be deleted.

There were also some other improvements that #349 attempted to make, and that could be followed up on. These were: closing Issues #244, #216.
@mairas
Copy link
Collaborator

mairas commented Apr 7, 2021

Caught this at the very last second! I'll still include these in the release.

mairas added a commit to mairas/SensESP-1 that referenced this issue Apr 7, 2021
@mairas
Remove unnecessary AHRS dependency.
86195a5 
Fixes SignalK#403.
Fixes SignalK#244.
Fixes SignalK#216
@mairas mairas mentioned this issue Apr 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary AHRS dependency mairas/SensESP-1
2 participants
@mairas @BjarneBitscrambler