Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ancient Debris doesn't grant Mining XP on 1.17 #63

Open
Neubulae opened this issue Jul 4, 2021 · 16 comments
Open

Ancient Debris doesn't grant Mining XP on 1.17 #63

Neubulae opened this issue Jul 4, 2021 · 16 comments
Labels
bug Something isn't working help wanted Extra attention is needed mod compatibility Something related to other mods

Comments

@Neubulae
Copy link

Neubulae commented Jul 4, 2021

So are deepslate ores, bruh

@SilverAndro SilverAndro added the bug Something isn't working label Jul 4, 2021
@SilverAndro
Copy link
Owner

Hm the deepslate versions should be falling back to the default 2 xp

@SilverAndro
Copy link
Owner

Can you check if both of these are still issues in 4.1.5?
(And if they are can you enable the new debug messages and show the log?)

@SilverAndro SilverAndro added the awaiting feedback Further information is requested label Jul 4, 2021
@Neubulae
Copy link
Author

Neubulae commented Jul 4, 2021

Seems like Deepslate Gold Ore and Ancient Debris still don't work? Diamond ore works now tho, haven't check others

@SilverAndro
Copy link
Owner

Well deepslate gold and ancient debris are both specified here, do you have the debug logs?

@Neubulae
Copy link
Author

Neubulae commented Jul 4, 2021

图片
This was shown in console, but in reality my stats didn't go up as I checked my stats thru /rpgstats

@SilverAndro
Copy link
Owner

Hm that's quite strange
Only thing I can think of is something messing with my CCA component, would a mod list be possible?

@Neubulae
Copy link
Author

Neubulae commented Jul 4, 2021

mods.txt
ignore the files ending in disabled

@SilverAndro
Copy link
Owner

Alright thanks, ill look into this

@SilverAndro SilverAndro removed the awaiting feedback Further information is requested label Jul 4, 2021
@Neubulae
Copy link
Author

I raised priority of RPGStats' mixins to 50 and the issue disappeared. I suppose this is due to mixin conflicts?

@SilverAndro
Copy link
Owner

Shoudn't be, that runs off the block break event (PlayerBlockBreakEvents.AFTER) 🤔

@Neubulae
Copy link
Author

Shoudn't be, that runs off the block break event (PlayerBlockBreakEvents.AFTER) thinking

huh.

@Neubulae Neubulae reopened this Jul 17, 2021
@SilverAndro
Copy link
Owner

Getting a chance to poke at this more, this is very strange

Your definitely getting the XP, so its failing to save for some reason, but why only for mining? Why only specific blocks?

My first thought would be with upgradeStatDataTov2, but that affects all stats, and CCA drops the data afterwards so its not that

Haven't had a chance to go though the modlist yet, but I guess thats my next step

@Neubulae
Copy link
Author

Getting a chance to poke at this more, this is very strange

Your definitely getting the XP, so its failing to save for some reason, but why only for mining? Why only specific blocks?

My first thought would be with upgradeStatDataTov2, but that affects all stats, and CCA drops the data afterwards so its not that

Haven't had a chance to go though the modlist yet, but I guess thats my next step

I changed mixin priority and worked, would that give any clue?
maybe somebody @Redirected…

@SilverAndro
Copy link
Owner

Dont know, I'll just have to put in the work to get everything downloaded

@Neubulae
Copy link
Author

After some testing I found out this problem being much weirder than expected:
I said it's working, right? No. It only works around half the time. I can dig up one debris while receiving no XP, and yet I dig another one that grants me XP.
By placing down and digging up, I receive XP only around 50% of the time. This is getting concerning.

@SilverAndro SilverAndro added help wanted Extra attention is needed mod compatibility Something related to other mods labels Jul 19, 2021
@chronosacaria
Copy link
Contributor

@Neubulae If I had to guess, it looks like there might be some server issues with GeyserMC. Whilst you did say you found out what the issue was, in the end, insomuch as you were receiving XP ~50% of the time (this is intentional), I am thinking that there were some conflicts that were happening between GeyserMC and RPGStats with respect to priority.

I would imagine that GeyserMC would need to maintain the highest priority in order to keep the clients in sync which would mess with other mods (only a theory), but if I had to put money on it, I would say that is where the issue is probably coming from

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed mod compatibility Something related to other mods
Projects
None yet
Development

No branches or pull requests

3 participants