From de2b36787200608efb519d77c02db68e207164a1 Mon Sep 17 00:00:00 2001
From: Simon <63975668+Simyon264@users.noreply.github.com>
Date: Fri, 22 Mar 2024 01:04:58 +0100
Subject: [PATCH] Hopefully increase performance + remove search limit

---
 Client/Components/Layout/MainLayout.razor | 24 ++++++++++++++++++++++-
 Client/Components/ReplayViewer.razor      | 12 ------------
 Server/Api/ReplayController.cs            |  2 +-
 Shared/Constants.cs                       |  6 ++++++
 4 files changed, 30 insertions(+), 14 deletions(-)
 create mode 100644 Shared/Constants.cs

diff --git a/Client/Components/Layout/MainLayout.razor b/Client/Components/Layout/MainLayout.razor
index d3e6294..337e06c 100644
--- a/Client/Components/Layout/MainLayout.razor
+++ b/Client/Components/Layout/MainLayout.razor
@@ -13,4 +13,26 @@
     An unhandled error has occurred.
     <a href="" class="reload">Reload</a>
     <a class="dismiss">🗙</a>
-</div>
\ No newline at end of file
+</div>
+
+<script>
+    // This is very cursed, but it works
+    // I move all modals to the modal-root div
+    // also every time a modal is created, it is appended to the modal-root div
+    const modalRoot = document.getElementById('modal-root');
+    const pageRoot = document.querySelector('.page');
+    
+    const modals = document.querySelectorAll('.modal');
+    modals.forEach(modal => {
+        modalRoot.appendChild(modal);
+    });
+    
+    // listen for when a div is created with the class modal and move it to the modal-root div
+    const observer = new MutationObserver(function(mutations) {
+        const modals = document.querySelectorAll('.modal');
+        modals.forEach(modal => {
+            modalRoot.appendChild(modal);
+        });
+    });
+    observer.observe(pageRoot, { childList: true, subtree: true });
+</script>
\ No newline at end of file
diff --git a/Client/Components/ReplayViewer.razor b/Client/Components/ReplayViewer.razor
index 0bb5568..8e4aec7 100644
--- a/Client/Components/ReplayViewer.razor
+++ b/Client/Components/ReplayViewer.razor
@@ -96,18 +96,6 @@
     <p>Oops! This component is missing a replay. Please report this to the developers.</p>
 }
 
-<script>
-    // This is very cursed, but it works
-    // I move the modal to the root of the document so it can be opened from anywhere
-    // this is because ReplayViewer may be rendered in a modal itself
-    // and modals can't be nested
-    var modals = document.querySelectorAll('.modal');
-    var modalRoot = document.getElementById('modal-root');
-    modals.forEach((modal) => {
-        modalRoot.appendChild(modal);
-    });
-</script>
-
 @code {
     [Parameter]
     public Shared.Models.Replay? Replay { get; set; }
diff --git a/Server/Api/ReplayController.cs b/Server/Api/ReplayController.cs
index 6a4e64f..4d08305 100644
--- a/Server/Api/ReplayController.cs
+++ b/Server/Api/ReplayController.cs
@@ -86,7 +86,7 @@ [FromQuery] string query
 
         var found = ReplayParser.SearchReplays(searchMode, query, _context);
         // Order found replays by date
-        found = found.OrderByDescending(r => r.Date ?? DateTime.MinValue).Take(32 * 3).ToList();
+        found = found.OrderByDescending(r => r.Date ?? DateTime.MinValue).Take(Constants.SearchLimit).ToList();
         
         return Ok(found);
     }
diff --git a/Shared/Constants.cs b/Shared/Constants.cs
new file mode 100644
index 0000000..4cff739
--- /dev/null
+++ b/Shared/Constants.cs
@@ -0,0 +1,6 @@
+namespace Shared;
+
+public class Constants
+{
+    public const int SearchLimit = int.MaxValue;
+}
\ No newline at end of file