Particular 1.1.1 mixin crash or safeguard trigger

[weegeeluigi]

Mod Name

Particular

Mod Homepage

https://modrinth.com/mod/particular

Minecraft version

1.21.1

Describe the bug

Mixin crash

Steps to reproduce

1. Install latest connector beta 5 for 1.21.1 neoforge
2. Install any version of particular for 1.21 (in this case I'm using latest 1.1.1)
3. Install owo-lib (either neo or fabric)
4. mixin crash if you install the neo version of owo-lib or it will trip the safeguard error screen if you install the fabric version
5. Uploaded log is for both loaders of owo-lib installed since some native neo-forge mods require owo-lib, this trips the mixin crash instead of safeguard

Logs

https://gist.github.com/weegeeluigi/81ce031c2b63d0c0e6a09456ee0e5024

Additional context

No response

[RedMenace0711]

I've experienced the same issue while trying to look for an alternative for Effective, owolib for fabric seems to be broken in general as i tried running just that mod with the connector and all and it results in a mixin safeguard and then a crash upon world creation

[weegeeluigi]

I've experienced the same issue while trying to look for an alternative for Effective, owolib for fabric seems to be broken in general as i tried running just that mod with the connector and all and it results in a mixin safeguard and then a crash upon world creation

Hmmm I don't have issues with owo-lib, I haven't played minecraft in a year but I upgraded my 1.20 sinytra pack and while still having about a dozen mods that haven't jumped to 1.21/neo, it's working fine. World gen works, dimension traveling works, no crashes so far with JEI. Granted it's just testing, but I have a bunch of mods that rely on owo-lib and haven't imploded yet. I have 195 mod jars installed. The only real issue besides this one is better end's broken block generation and excessive building, but that's moreso an issue the neoforge port isn't available just yet.

[RedMenace0711]

You say you got mods that haven't been upgraded yet to work on your 1.21 modpack? Idk how you did that lol, but owolib for fabric never worked for me and all i had was the connector mods in there with it, its only the fabric version of owolib, it crashes either upon starting the game or world generation

[weegeeluigi]

No, I have a billion mods installed while still waiting on the rest and it still works. It was a nice way of saying I think you're doing something goofy as I have a ton of owo-lib dependent mods that aren't crashing.

Effective will crash with or without owo-lib anyways as it more or less works the same was as Particular. The issue is something connector does or potentially even how particular was rewritten.

[RedMenace0711]

Alright, I've tested it over and over 3 more times now and tested it on fabric also just to be absolutely sure and as I was saying, the FABRIC version of owolib does not work on the connector, that's all i was saying, launching the 1.21.1 version of the connector(the latest at the time of me writing this) of both the connector and FABRIC owolib will lead to a mixin error, then if you choose to launch it again after that, you always get a crash upon world creation.

[RedMenace0711]

If you dont want to test it out yourself to confirm then I'll be happy to submit my own issue specifically about owolib not being compatible with the logs for proof

[weegeeluigi]

Yeah it insta bombs so it's doing something funky with mixins that connector doesn't like.

[RedMenace0711]

Update: The same issues still arise on beta 6

[weegeeluigi]

Update: The same issues still arise on beta 6

I'm not surprised since beta 6 didn't really change anything apart from fixing the crash preventing .97 from being usable.

With that said, try this again. On .115 right now that doesn't crash for me with beta 6, and also there's a sneaky FFAPI update a few days ago. With the new FFAPI having both platform libs in the folder doesn't crash anymore. I'm not sure if it's just skipping the fabric one but it loads no problem.

Particular still implodes though, new log attached @Su5eD : https://gist.github.com/weegeeluigi/e8a5d0eefc8b420545585e4c17ae03cf

UPDATE: Ok celebrated that a little too soon. The fabric version is still broken, I was suspicious in that crash log and for some fun reason it completely skipped over it. Blew away the connector folder and it quickly threw the mixin error.

UPDATE 2:

@RedMenace0711 I fixed the issue by side-stepping the real problem and building a custom fork. I have owo 0.12.11 for fabric loaded I haven't yet tried anything above it. owo-lib isn't the issue here (maybe the higher versions have a problem with sinytra, but this one does not).

@Su5eD The issue is the on-the-fly embedded build of sushi-bar, primarily. I found this whole thing strange from the start given particular always depended on it's partner library mod, I looked at the 1.21 source and found instead the dev shoe-horned in a "1.21" version of sushi-bar in code with particular vs porting the library itself to 1.21 right now, and this gets the mod out the door. The injector mixin for the mod menu integration for the config file blows up. That's the main issue.

The getWeather() mixin from biomes (throws a no method found) so fireflies have to be disabled to avoid another crash. Maybe it's a connector quirk, maybe the mod is rough around the edges, but I figured given the back and forth and dubious nature of what's broken here I'd be thorough so we know what's up.

[Eeveermore]

I fixed the issue by side-stepping the real problem and building a custom fork. I have owo 0.12.11 for fabric loaded I haven't yet tried anything above it. owo-lib isn't the issue here (maybe the higher versions have a problem with sinytra, but this one does not).

Any possibility of this fork you built being available for use?

[weegeeluigi]

I fixed the issue by side-stepping the real problem and building a custom fork. I have owo 0.12.11 for fabric loaded I haven't yet tried anything above it. owo-lib isn't the issue here (maybe the higher versions have a problem with sinytra, but this one does not).

Any possibility of this fork you built being available for use?

I didn't plan to make this a real fix, since it's not a fix it just removes the classes that use the mixins that crash connector. This was an experiment to test my original theory owo-lib wasn't the root cause. If you really want a working build I can make a public fork this weekend, but the root issue should get solved vs a hackjob fix that disabled in game config editing and an entire feature.

[Eeveermore]

I didn't plan to make this a real fix, since it's not a fix it just removes the classes that use the mixins that crash connector. This was an experiment to test my original theory owo-lib wasn't the root cause. If you really want a working build I can make a public fork this weekend, but the root issue should get solved vs a hackjob fix that disabled in game config editing and an entire feature.

100% agree that the root issue being solved would be much more preferable. If you've got the spare time tho, a public fork working build to use while waiting for an actual fix would be wonderful, even in a limited state.

[weegeeluigi]

I didn't plan to make this a real fix, since it's not a fix it just removes the classes that use the mixins that crash connector. This was an experiment to test my original theory owo-lib wasn't the root cause. If you really want a working build I can make a public fork this weekend, but the root issue should get solved vs a hackjob fix that disabled in game config editing and an entire feature.

100% agree that the root issue being solved would be much more preferable. If you've got the spare time tho, a public fork working build to use while waiting for an actual fix would be wonderful, even in a limited state.

https://github.com/weegeeluigi/particular-connector-fix/releases/tag/v1.1.1-custom

Anyone who uses this workaround for now please do NOT PUBLISH THIS on curseforge or modrinth. This is literally a hacked workaround disabling the accessor biome and sushi mod menu config injection mixins. Disable fireflies in your config and particular should now work.

[PartTimeStarfish]

I didn't plan to make this a real fix, since it's not a fix it just removes the classes that use the mixins that crash connector. This was an experiment to test my original theory owo-lib wasn't the root cause. If you really want a working build I can make a public fork this weekend, but the root issue should get solved vs a hackjob fix that disabled in game config editing and an entire feature.

100% agree that the root issue being solved would be much more preferable. If you've got the spare time tho, a public fork working build to use while waiting for an actual fix would be wonderful, even in a limited state.

https://github.com/weegeeluigi/particular-connector-fix/releases/tag/v1.1.1-custom

Anyone who uses this workaround for now please do NOT PUBLISH THIS on curseforge or modrinth. This is literally a hacked workaround disabling the accessor biome and sushi mod menu config injection mixins. Disable fireflies in your config and particular should now work.

I think what you're doing is really amazing. I was able to get past the initial loading menu. When generating a new world, I received this error:

"Error: java.lang.NoSuchMethodError: 'net.minecraft.world.level.biome.Biome$ClimateSettings com.chailotl.particular.mixin.AccessorBiome.connector$redirect$getWeather()'"

I'm not sure if you will see this, but I really appreciate what you've done. Thank you in advance.

Edit: How do you mean "Disable Fireflies in your config"?

[weegeeluigi]

I didn't plan to make this a real fix, since it's not a fix it just removes the classes that use the mixins that crash connector. This was an experiment to test my original theory owo-lib wasn't the root cause. If you really want a working build I can make a public fork this weekend, but the root issue should get solved vs a hackjob fix that disabled in game config editing and an entire feature.

100% agree that the root issue being solved would be much more preferable. If you've got the spare time tho, a public fork working build to use while waiting for an actual fix would be wonderful, even in a limited state.

https://github.com/weegeeluigi/particular-connector-fix/releases/tag/v1.1.1-custom
Anyone who uses this workaround for now please do NOT PUBLISH THIS on curseforge or modrinth. This is literally a hacked workaround disabling the accessor biome and sushi mod menu config injection mixins. Disable fireflies in your config and particular should now work.

I think what you're doing is really amazing. I was able to get past the initial loading menu. When generating a new world, I received this error:

"Error: java.lang.NoSuchMethodError: 'net.minecraft.world.level.biome.Biome$ClimateSettings com.chailotl.particular.mixin.AccessorBiome.connector$redirect$getWeather()'"

I'm not sure if you will see this, but I really appreciate what you've done. Thank you in advance.

Edit: How do you mean "Disable Fireflies in your config"?

Go to particular's config file and change the fireflies option to false. That one uses the biome mixin and crashes. I haven't tested particular on beta7 yet.

[PartTimeStarfish]

I didn't plan to make this a real fix, since it's not a fix it just removes the classes that use the mixins that crash connector. This was an experiment to test my original theory owo-lib wasn't the root cause. If you really want a working build I can make a public fork this weekend, but the root issue should get solved vs a hackjob fix that disabled in game config editing and an entire feature.

100% agree that the root issue being solved would be much more preferable. If you've got the spare time tho, a public fork working build to use while waiting for an actual fix would be wonderful, even in a limited state.

https://github.com/weegeeluigi/particular-connector-fix/releases/tag/v1.1.1-custom
Anyone who uses this workaround for now please do NOT PUBLISH THIS on curseforge or modrinth. This is literally a hacked workaround disabling the accessor biome and sushi mod menu config injection mixins. Disable fireflies in your config and particular should now work.

I think what you're doing is really amazing. I was able to get past the initial loading menu. When generating a new world, I received this error:
"Error: java.lang.NoSuchMethodError: 'net.minecraft.world.level.biome.Biome$ClimateSettings com.chailotl.particular.mixin.AccessorBiome.connector$redirect$getWeather()'"
I'm not sure if you will see this, but I really appreciate what you've done. Thank you in advance.
Edit: How do you mean "Disable Fireflies in your config"?

Go to particular's config file and change the fireflies option to false. That one uses the biome mixin and crashes. I haven't tested particular on beta7 yet.

Thank you so so much. It works now. Why does this bug happen?

[weegeeluigi]

I didn't plan to make this a real fix, since it's not a fix it just removes the classes that use the mixins that crash connector. This was an experiment to test my original theory owo-lib wasn't the root cause. If you really want a working build I can make a public fork this weekend, but the root issue should get solved vs a hackjob fix that disabled in game config editing and an entire feature.

100% agree that the root issue being solved would be much more preferable. If you've got the spare time tho, a public fork working build to use while waiting for an actual fix would be wonderful, even in a limited state.

https://github.com/weegeeluigi/particular-connector-fix/releases/tag/v1.1.1-custom
Anyone who uses this workaround for now please do NOT PUBLISH THIS on curseforge or modrinth. This is literally a hacked workaround disabling the accessor biome and sushi mod menu config injection mixins. Disable fireflies in your config and particular should now work.

I think what you're doing is really amazing. I was able to get past the initial loading menu. When generating a new world, I received this error:
"Error: java.lang.NoSuchMethodError: 'net.minecraft.world.level.biome.Biome$ClimateSettings com.chailotl.particular.mixin.AccessorBiome.connector$redirect$getWeather()'"
I'm not sure if you will see this, but I really appreciate what you've done. Thank you in advance.
Edit: How do you mean "Disable Fireflies in your config"?

Go to particular's config file and change the fireflies option to false. That one uses the biome mixin and crashes. I haven't tested particular on beta7 yet.

Thank you so so much. It works now. Why does this bug happen?

Your typical mixin conflict on connector. I think the 1.21 port of particular was rushed, but it's def a connector issue. Give it time and it will get fixed.