Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin sets logging level to 'fatal' regardless of options received from the outside #103

Open
Owersun opened this issue Jun 24, 2024 · 0 comments

Comments

@Owersun
Copy link

Owersun commented Jun 24, 2024

logLevel: 'fatal',

This sets logging level of the /metrics route to "fatal", even when I provide "logLevel" to the options during registration (which is completely ignored then).
a) is it intended that the logging level is FATAL for metrics? isn't it too much?..
b) can you please either inherit parent logLevel, accept external options logLevel and only then default to fatal.

I don't think a lot of people are interested in getting "GET /metrics" log every 30 seconds day and night...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant