Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timepsan Infinity #7458

Open
1 task done
ShaneBeee opened this issue Jan 16, 2025 · 0 comments
Open
1 task done

Timepsan Infinity #7458

ShaneBeee opened this issue Jan 16, 2025 · 0 comments
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. good first issue An issue that would be good for a first-time contributor to make a PR for priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@ShaneBeee
Copy link
Contributor

ShaneBeee commented Jan 16, 2025

Suggestion

Skript's Timespan should support infinity.
Potion effects with a time of -1 are considered infinite.
Returning the timespan from a potion that is infinite is impossible since Timespan requires 0+ milliseconds.

Suggestion:

  • An infinite boolean field definition that the timespan is infinite.
  • A new constructor to create an infinite timespan (which can set milliseconds to -1 and set the infinite field to true
  • A method to return infinite

Why?

In SkBee I have an expression timespan of %potioneffect%, my only option is to return a timespan with Long/Integer.MAX_VALUE.
This isn't what I really want.

Not to mention if Skript ever has this expression (which it should), its going to have the same issue.

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this suggestion.
@Moderocky Moderocky added enhancement Feature request, an issue about something that could be improved, or a PR improving something. good first issue An issue that would be good for a first-time contributor to make a PR for priority: low Issues that are not harmful to the experience but are related to useful changes or additions. labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. good first issue An issue that would be good for a first-time contributor to make a PR for priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Development

No branches or pull requests

2 participants