Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name of Block no longer works #7502

Closed
1 task done
ShaneBeee opened this issue Jan 22, 2025 · 2 comments
Closed
1 task done

Name of Block no longer works #7502

ShaneBeee opened this issue Jan 22, 2025 · 2 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.

Comments

@ShaneBeee
Copy link
Contributor

ShaneBeee commented Jan 22, 2025

Skript/Server Version

> sk info
[17:17:25 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[17:17:25 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[17:17:25 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[17:17:25 INFO]: [Skript] Server Version: 1.21.4-118-73f7736 (MC: 1.21.4)
[17:17:25 INFO]: [Skript] Skript Version: 2.10.0 (skriptlang-github)
[17:17:25 INFO]: [Skript] Installed Skript Addons: None
[17:17:25 INFO]: [Skript] Installed dependencies: None

Bug Description

I noticed that since Skript 2.10, the name of expression no longer seems to work on blocks.

Expected Behavior

I should be able to get/set the name of a block.

Steps to Reproduce

  1. Give yourself a named furnace
  2. Place it
  3. send "Name: %name of target block%" (While looking at it)

Errors or Screenshots

Skript 2.9.5:
Image

Skript 2.10.0:
Image

Other

After doing some digging and throwing a bunch of debug lines in, I came to the conclusion that the Block is getting converted to an inventory before it has a chance to get converted to AnyNamed.

patterns.addAll(Arrays.asList(getPatterns("name[s]", "offlineplayers/entities/inventories/nameds")));

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@erenkarakal erenkarakal added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. PR available Issues which have a yet-to-be merged PR resolving it labels Jan 22, 2025
@Moderocky Moderocky added the completed The issue has been fully resolved and the change will be in the next Skript update. label Jan 28, 2025
@ShaneBeee
Copy link
Contributor Author

@erenkarakal why was this closed? Theres been no release yet?

@erenkarakal
Copy link
Member

Apologies, I thought it was depending on the PR state 😬

@erenkarakal erenkarakal reopened this Jan 28, 2025
@APickledWalrus APickledWalrus added patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.
Projects
None yet
Development

No branches or pull requests

4 participants