You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please answer these questions before submitting your issue.
Why do you submit this issue?
Question or discussion
Bug
Requirement
Feature or performance improvement
Question
What do you want to know?
Currently, when calling SegmentSpan.ErrorOccurred(Exception, TracingConfig), you need to pass in the TracingConfig parameter. Is it better to move the logic of ErrorOccurred into TracingContext? TracingContext can hold a TracingConfig object, which is much more convenient than getting a TracingConfig every time ErrorOccurred is called.
现在我们调用SegmentSpan.ErrorOccurred(Exception, TracingConfig)方法的时候需要传入TracingConfig参数,将ErrorOccurred的逻辑移动到TracingContext中是否更好?TracingContext可以持有一个TracingConfig对象,相比每次调用ErrorOccurred都去获取一个TracingConfig会方便很多。
Or TracingContext exposes a TracingConfig property, and then adds ErrorOccurred method to TracingContext by way of extension method.
或者TracingContext暴露一个TracingConfig属性,然后通过扩展方法的方式为TracingContext增加ErrorOccurred方法。
Please answer these questions before submitting your issue.
Question
Currently, when calling
SegmentSpan.ErrorOccurred(Exception, TracingConfig)
, you need to pass in theTracingConfig
parameter. Is it better to move the logic ofErrorOccurred
intoTracingContext
?TracingContext
can hold aTracingConfig
object, which is much more convenient than getting aTracingConfig
every timeErrorOccurred
is called.现在我们调用
SegmentSpan.ErrorOccurred(Exception, TracingConfig)
方法的时候需要传入TracingConfig
参数,将ErrorOccurred
的逻辑移动到TracingContext
中是否更好?TracingContext
可以持有一个TracingConfig
对象,相比每次调用ErrorOccurred
都去获取一个TracingConfig
会方便很多。Bug
Which version of SkyWalking, OS and .NET Runtime?
Which company or project?
What happen?
If possible, provide a way for reproducing the error. e.g. demo application, component version.
Requirement or improvement
The text was updated successfully, but these errors were encountered: