From d7e8ea51835e2d40c75aea490451af63abd57464 Mon Sep 17 00:00:00 2001 From: Jean-Christophe Fillion-Robin Date: Thu, 4 Apr 2024 21:26:19 -0400 Subject: [PATCH] CI: Simplify check_description_files removing obsolete --check-git-repository-name Following 553c045 ("CI: Update check_git_repository_name hard-coding exceptions", 2024-03-12), exceptions are hard-coded and there is no need to run the check only for new files. --- .circleci/config.yml | 2 +- scripts/check_description_files.py | 7 +------ 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 4439f42e4..cf42bd7b2 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -57,7 +57,7 @@ jobs: # Run checks if [[ $added != "" ]]; then pip install joblib retry - python ./scripts/check_description_files.py --check-git-repository-name $added + python ./scripts/check_description_files.py $added fi workflows: diff --git a/scripts/check_description_files.py b/scripts/check_description_files.py index 15c3132a7..eef7117db 100644 --- a/scripts/check_description_files.py +++ b/scripts/check_description_files.py @@ -242,9 +242,6 @@ def check_dependencies(directory): def main(): parser = argparse.ArgumentParser( description='Validate extension description files.') - parser.add_argument( - "--check-git-repository-name", action="store_true", - help="Check extension git repository name. Disabled by default.") parser.add_argument( "--check-urls-reachable", action="store_true", help="Check homepage, iconurl and screenshoturls are reachable. Disabled by default.") @@ -254,14 +251,12 @@ def main(): checks = [] - if args.check_git_repository_name: - checks.append((check_git_repository_name, {})) - if not checks: checks = [ (check_category, {}), (check_contributors, {}), (check_description, {}), + (check_git_repository_name, {}), (check_homepage, {"check_url_reachable": args.check_urls_reachable}), (check_iconurl, {"check_url_reachable": args.check_urls_reachable}), (check_scmurl_syntax, {}),