Farmland Moisture check showing incorrect results

[TheBusyBiscuit]

📍 Description (REQUIRED)

The Moisture Checker shows wrong results when using it on wet farmland, it seems to always give off the "yellow indicator", no matter if wet or dry.

This is the farmland:

This is what is shown after using a Moisture Checker:

As evidently shown, the Moisture Checker has a yellow indicator for both, wet and dry, farmland.

📑 Steps to reproduce the Issue (REQUIRED)

1. Set up some farmland
2. Place water next to it
3. Wait for farmland to get wet
4. Right click with a Moisture Checker

💡 Expected behavior (REQUIRED)

The Moisture Checker should show different levels of moisture depending on whether the farmland is wet or not.

📜 Server Log

No significant data in the logs

🧭 Environment (REQUIRED)

• Server Software (Spigot/Paper): Paper (git-204)
• Minecraft Version: 1.16.3
• SensibleToolbox Version: DEV - 1 @ b0ab4a7

[wouterdedroog]

This issue doesn't seem to happen after watering it with a watering can (/stb give wateringcan). This happens because soil that doesn't get watered with a watering can doesn't have any metadata with the STB_Saturation metadata key. Is this a bug? @TheBusyBiscuit

[TheBusyBiscuit]

@MrWouterNL Well, the saturation can be seen as a water "overflow" thing.
There is dry soil, wet soil and then there is a few levels of "saturated" soil.
It is correct that non-saturated soil has no metadata value assigned to it.
But I think the normal dry and wet variants should still be visually indicated in some form.