Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes BSU and HSU dupe #85

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Sefiraat
Copy link
Member

@Sefiraat Sefiraat commented Jul 4, 2021

Description

Users could pull an extra item from BSUs and HSUs using the COLLECT_TO_CURSOR InventoryAction. I have added a lore line to the display 'progress' item to stop it being stackable for this action.

Changes

Added a new method that adds a single lore line to the ItemStack that is sent to setProcessing which also give the item meaning to the viewing player

Related Issues

Resolves #80

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values

@Sefiraat Sefiraat requested a review from a team as a code owner July 4, 2021 21:07
@Sefiraat Sefiraat requested a review from WalshyDev July 6, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BSU Dupe Bug Report
3 participants