Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When researching coal generator, if you leave and rejoin after save, coal generator is un-researched #4123

Closed
4 tasks done
yenseo7009 opened this issue Feb 8, 2024 · 6 comments · Fixed by #4124
Closed
4 tasks done

When researching coal generator, if you leave and rejoin after save, coal generator is un-researched #4123

yenseo7009 opened this issue Feb 8, 2024 · 6 comments · Fixed by #4124
Labels
🐞 Bug Report A bug that needs to be fixed. 🧨 Confirmed Bug This bug has been confirmed by our team. ✔ Resolved This Issue has been resolved.

Comments

@yenseo7009
Copy link

yenseo7009 commented Feb 8, 2024 •
edited
Loading

❗ Checklist

  • I am using the official english version of Slimefun and did not modify the jar.
  • I am using an up to date "DEV" (not "RC") version of Slimefun.
  • I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
  • I searched for similar open issues and could not find an existing bug report on this.

📍 Description

when researched coal generator and leave and rejoin, coal generator un-researched

📑 Reproduction Steps

  1. see coal generator researched
  2. leave and rejoin after few minutes
  3. you can see coal generator un-researched

💡 Expected Behavior

boris expected coal generator research progress loaded properly after rejoining server

📷 Screenshots / Videos

2024-02-08_22 31 54
2024-02-08_22 14 52

📜 Server Log

No response

📂 /error-reports/ folder

No response

💻 Server Software

Paper

🎮 Minecraft Version

1.20.x

⭐ Slimefun version

dev-1133

🧭 Other plugins

No response
@yenseo7009 yenseo7009 added 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. 🐞 Bug Report A bug that needs to be fixed. labels Feb 8, 2024
@yenseo7009
Copy link
Author

up: after
down: before

@J3fftw1
Copy link
Contributor

J3fftw1 commented Feb 8, 2024

This is the second report of this.

@WalshyDev
Copy link
Member

Could you provide your plugin list and also logs?

@yenseo7009
Copy link
Author

Boris not server staff, boris sorry

@yenseo7009
Copy link
Author

So boris will wait until staffs provide that

@yenseo7009
Copy link
Author

image-1
image-2
Here's the plugin list

@WalshyDev WalshyDev changed the title (this is a important bug that wastes xp) when researched coal generator and leave and rejoin, coal generator un-researched When researching coal generator, if you leave and rejoin after save, coal generator is un-researched Feb 10, 2024
@WalshyDev WalshyDev added 🧨 Confirmed Bug This bug has been confirmed by our team. and removed 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. labels Feb 10, 2024
WalshyDev added a commit that referenced this issue Feb 10, 2024
@WalshyDev
Fixes #4123 - Coal Generator will no longer be locked after researching
6f1c8f1 
Due to a logic bug in the Legacy storage backend if there was a duplicate ID it would mark it as researched for the first, then see it researched already and remove it on the second. This was happening for the Coal Generator and Bio Reactor here. Both shared he same research ID 173.

We're just doing this fix for now until we can move away from the legacy backend (work in progress).
@WalshyDev WalshyDev mentioned this issue Feb 10, 2024
Merged
7 tasks
WalshyDev added a commit that referenced this issue Feb 10, 2024
@WalshyDev
Fixes #4123 - Coal Generator will no longer be locked after researchi…
98bc59e 
…ng (#4124)

Due to a logic bug in the Legacy storage backend if there was a duplicate ID it would mark it as researched for the first, then see it researched already and remove it on the second. This was happening for the Coal Generator and Bio Reactor here. Both shared he same research ID 173.

We're just doing this fix for now until we can move away from the legacy backend (work in progress).
@TheBusyBot TheBusyBot added the ✔ Resolved This Issue has been resolved. label Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 Bug Report A bug that needs to be fixed. 🧨 Confirmed Bug This bug has been confirmed by our team. ✔ Resolved This Issue has been resolved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #4123 - Coal Generator will no longer be locked after researching Slimefun/Slimefun4
4 participants
@WalshyDev @TheBusyBot @J3fftw1 @yenseo7009