Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move scripts (JS files) and images into a scripts folder and the images folder respectively for a cleaner folder structure. #35

Open
rajneesh069 opened this issue Jan 1, 2024 · 2 comments
Assignees

Comments

@rajneesh069
Copy link
Contributor

rajneesh069 commented Jan 1, 2024

Fix :-
image

image

I want to work on the issue if it gets approved.

@rajneesh069 rajneesh069 changed the title Move scripts (JS files) into a scripts folder for cleaner folder structure. Move scripts (JS files) and images into a scripts folder and the images folder respectively for cleaner folder structure. Jan 1, 2024
@rajneesh069 rajneesh069 changed the title Move scripts (JS files) and images into a scripts folder and the images folder respectively for cleaner folder structure. Move scripts (JS files) and images into a scripts folder and the images folder respectively for a cleaner folder structure. Jan 1, 2024
@nisha-laur
Copy link
Contributor

@rajneesh069 You can do that but after that please make sure that you change the images path in all the code lines where it is required and similarly for the js files . It should not disturb the the flow of the Application.

@rajneesh069
Copy link
Contributor Author

rajneesh069 commented Jan 2, 2024

@nisha-laur Oh yeah I've made sure of the path images don't worry. 😁 Umm btw, like the other issues haven't been approved so should I just move the app.js file into the scripts folder? Because for other .js files I'll need approval of other issues. Also, I'm a bit confused as for this to happen all the pull requests need to be merged before because those will lead to the scripts tag moved into the head tag and the internal CSS styling to be moved into the external CSS file and other stuff like that, so I'll have to wait for that right? Or is there any other way around, as changing the paths right now would create a merger conflict later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants