Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_queue assumes the presence of attributes on queue items. #74

Open
c-nixon opened this issue Jun 18, 2018 · 0 comments
Open

get_queue assumes the presence of attributes on queue items. #74

c-nixon opened this issue Jun 18, 2018 · 0 comments

Comments

@c-nixon
Copy link

c-nixon commented Jun 18, 2018

get_queue in core.py often fails with an Attribute error when a track from soundcloud is on the playlist.

Replacing

track.creator,
track.title,
track.album,

with

getattr(track, "creator", ""),
getattr(track, "title", ""),
getattr(track, "album", ""),

on lines 436:438

fixes the problem, but this is a bit messy.

I'm happy to put in a PR for this, but would like suggestions as what people think is the best to fix it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@c-nixon