Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jquery-rails should not be a dependency #40

Open
shaneog opened this issue Nov 14, 2014 · 3 comments
Open

jquery-rails should not be a dependency #40

shaneog opened this issue Nov 14, 2014 · 3 comments

Comments

@shaneog
Copy link

shaneog commented Nov 14, 2014

It should be up to the gem user to decide how to integrate jQuery in her project.

For example, I use jQuery via bower and I don't want to add jquery-rails as a dependency of my project.

@ljachymczyk
Copy link
Member

What about jquery-ujs?

@akostadinov
Copy link
Contributor

akostadinov commented Oct 8, 2017

jquery-ujs is shipped inside jquery-rails gem. I guess user can install it externally as well.

FYI for Rails 5.1 I figured by trial and error that you need to disable rails-ujs and require jquery_ujs. Otherwise forms get submitted twice.

@wynksaiddestroy
Copy link
Contributor

I second the removal of jQuery as a dependency. I'm currently integrating jQuery via Rails Assets. So jQuery gets included and loaded twice when I use the Smart Listing gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants