Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/academic calendar schema #11

Closed
czaja307 opened this issue Nov 17, 2024 · 4 comments
Closed

chore/academic calendar schema #11

czaja307 opened this issue Nov 17, 2024 · 4 comments
Assignees

Comments

@czaja307
Copy link
Member

No description provided.

@mateusz-plaska
Copy link
Contributor

Image

This is db schema for academic calendar. I have added two extra tables which are not currently in existing model. I think tables "holidays" and "events" might be useful in the future but that is only my suggestion.

@czaja307
Copy link
Member Author

here are some comments:

  1. I prefer using text over varchars whenever possible, when using postgreSQL(https://stackoverflow.com/questions/4848964/difference-between-text-and-varchar-character-varying)
  2. I'm not a fan of storing recurring holidays this way - either omit it and store new instance in every calendar (personally i'd go with this one) or create new table with recurring holidays
  3. Events calendar is scope of another task feat/event calendar #3 (it needs some more discussion so leave it or now - you can post the current events table there for future reference)

@mateusz-plaska
Copy link
Contributor

Image

Right, here is the corrected schema - without 'current events' table.
Should I add this table to the schema? And if so, how should it look like (id, academic_calendar_id, event_id - taken this from the 'events calendar' table of another task)?
But will this table be necessary and useful for us?

@czaja307
Copy link
Member Author

Schema looks good, great job!
When it comes to events table you can add your version of it as-is into the #3 - it's a solid starting point for that task, which comes later in our roadmap.

@github-project-automation github-project-automation bot moved this from In review to Done in ToPWR Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants